Clean up some old code

pwndbg/commands/misc.py

@@ -6,6 +6,7 @@ import pwndbg as _pwndbg
 
 import pwndbg.arch as _arch
 import pwndbg.commands
+import pwndbg.symbol
 import pwndbg.regs
 
 
@@ -16,7 +17,9 @@ def errno(err=None):
     '''Converts errno (or argument) to its string representation'''
     if err is None:
         # Dont ask.
-        err = int(gdb.parse_and_eval('*((int *(*) (void)) __errno_location) ()'))
+        errno_location = pwndbg.symbol.get('__errno_location')
+        err = pwndbg.memory.int(errno_location)
+        # err = int(gdb.parse_and_eval('*((int *(*) (void)) __errno_location) ()'))
 
     err = abs(int(err))
 

pwndbg/elf.py

@@ -77,7 +77,7 @@ def entry():
     # Try common names
     for name in ['_start', 'start', '__start', 'main']:
         try:
-            return int(gdb.parse_and_eval(name))
+            return pwndbg.symbol.get(name)
         except gdb.error:
             pass
 
@@ -106,7 +106,7 @@ def get_ehdr(pointer):
 
     Example:
 
-        >>> pwndbg.elf.load(gdb.parse_and_eval('$pc'))
+        >>> pwndbg.elf.load(pwndbg.regs.pc)
         [Page('400000-4ef000 r-xp 0'),
          Page('6ef000-6f0000 r--p ef000'),
          Page('6f0000-6ff000 rw-p f0000')]
@@ -192,7 +192,7 @@ def map(pointer, objfile=''):
 
     Example:
 
-        >>> pwndbg.elf.load(gdb.parse_and_eval('$pc'))
+        >>> pwndbg.elf.load(pwndbg.regs.pc)
         [Page('400000-4ef000 r-xp 0'),
          Page('6ef000-6f0000 r--p ef000'),
          Page('6f0000-6ff000 rw-p f0000')]

pwndbg/regs.py

@@ -171,7 +171,7 @@ powerpc = RegisterSet(  retaddr = ('lr','r0'),
 # %o0 == %r8                          \
 # ...                                 | o stands for output (note: not 0)
 # %o6 == %r14 == %sp (stack ptr)      |
-# %o7 == %r15 == for return address   |
+# %o7 == %r15 == for return aaddress   |
 # ____________________________________/
 # %l0 == %r16                         \
 # ...                                 | l stands for local (note: not 1)
@@ -345,18 +345,6 @@ class module(ModuleType):
         for regname in self.all:
             yield regname, self[regname]
 
-    @property
-    def arguments(self):
-        argnames = arch_to_regs[pwndbg.arch.current].args
-        retval   = []
-        for arg in argnames:
-            val = self[arg]
-            if val is None:
-                try:    val = gdb.parse_and_eval(arg)
-                except: val = '???'
-            retval.append(val)
-        return retval
-
     arch_to_regs = arch_to_regs
 
     @property