Make shebangs and other bash usage portable (#2179)

profiling/benchmark.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # Benchmark context command
 make test > /dev/null
 git log --abbrev-commit --pretty=oneline HEAD^..HEAD

profiling/profile.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 if ! (($#)); then
     cat <<- _EOF_

setup-dev.sh

@@ -1,4 +1,5 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+set -e
 
 echo "# --------------------------------------"
 echo "# Install testing tools."
@@ -8,7 +9,7 @@ echo "# --------------------------------------"
 hook_script_path=".git/hooks/pre-push"
 hook_script=$(
     cat << 'EOF'
-#!/bin/bash
+#!/usr/bin/env bash
 
 diff_command="git diff --no-ext-diff --ignore-submodules"
 

tests/gdb-tests/tests/test_attachp.py

@@ -29,7 +29,8 @@ REASON_CANNOT_ATTACH = (
 @pytest.fixture
 def launched_bash_binary():
     path = tempfile.mktemp()
-    subprocess.check_output(["cp", "/bin/bash", path])
+    bash_path = subprocess.check_output(["which", "bash"]).decode().strip()
+    subprocess.check_output(["cp", bash_path, path])
 
     process = subprocess.Popen([path], stdout=subprocess.PIPE, stdin=subprocess.PIPE)
 

tests/qemu-tests/download_images.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -o errexit
 

tests/qemu-tests/test_qemu.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 make -C binaries