tests reference-binary.c: dont rely on connect to 1.1.1.1 (#1390)

setup-dev.sh

@@ -91,7 +91,8 @@ install_apt() {
         curl \
         build-essential \
         gdb \
-        parallel
+        parallel \
+	netcat-openbsd
 
     if [[ "$1" == "22.04" ]]; then
         sudo apt install shfmt

tests/gdb-tests/tests/binaries/reference-binary-net.c

@@ -0,0 +1,36 @@
+#include <arpa/inet.h>
+#include <stdio.h>
+
+#define PORT 31337
+
+void break_here() {};
+
+int main(int argc, char const* argv[]) {
+    puts("Hello World");
+
+    int sock = 0, client_fd;
+    struct sockaddr_in serv_addr;
+
+    if ((sock = socket(AF_INET, SOCK_STREAM, 0)) < 0) {
+        perror("socket");
+        return -1;
+    }
+
+    serv_addr.sin_family = AF_INET;
+    serv_addr.sin_port = htons(PORT);
+
+    if (inet_pton(AF_INET, "127.0.0.1", &serv_addr.sin_addr) <= 0) {
+        perror("inet_pton");
+        return -1;
+    }
+
+    if ((client_fd = connect(sock, (struct sockaddr*)&serv_addr, sizeof(serv_addr))) < 0) {
+        perror("connect");
+        return -1;
+    }
+
+    break_here();
+
+    close(client_fd);
+    return 0;
+}

tests/gdb-tests/tests/binaries/reference-binary.c

@@ -1,36 +1,11 @@
-#include <arpa/inet.h>
 #include <stdio.h>
 
-#define PORT 80
-
 void break_here() {};
 
 int main(int argc, char const* argv[]) {
     puts("Hello World");
 
-    int sock = 0, client_fd;
-    struct sockaddr_in serv_addr;
-
-    if ((sock = socket(AF_INET, SOCK_STREAM, 0)) < 0) {
-        perror("socket");
-        return -1;
-    }
-
-    serv_addr.sin_family = AF_INET;
-    serv_addr.sin_port = htons(PORT);
-
-    if (inet_pton(AF_INET, "1.1.1.1", &serv_addr.sin_addr) <= 0) {
-        perror("inet_pton");
-        return -1;
-    }
-
-    if ((client_fd = connect(sock, (struct sockaddr*)&serv_addr, sizeof(serv_addr))) < 0) {
-        perror("connect");
-        return -1;
-    }
-
     break_here();
 
-    close(client_fd);
     return 0;
 }

tests/gdb-tests/tests/test_command_procinfo.py

@@ -1,12 +1,16 @@
+import os
+
 import gdb
 
 import tests
 
-REFERENCE_BINARY = tests.binaries.get("reference-binary.out")
+REFERENCE_BINARY_NET = tests.binaries.get("reference-binary-net.out")
 
 
 def test_command_procinfo(start_binary):
-    start_binary(REFERENCE_BINARY)
+    start_binary(REFERENCE_BINARY_NET)
+
+    os.system("nc -l -p 31337 2>/dev/null 1>&2 &")
 
     bin_path = gdb.execute("pi pwndbg.gdblib.proc.exe", to_string=True).strip("\n")
     pid = gdb.execute("pi pwndbg.gdblib.proc.pid", to_string=True).strip("\n")
@@ -19,7 +23,7 @@ def test_command_procinfo(start_binary):
 
     assert bin_path in res_list[0]
     assert pid in res_list[1]
-    assert "1.1.1.1:80" in result
+    assert "127.0.0.1:31337" in result
 
 
 def test_command_procinfo_before_binary_start():