Make setup.sh return non-zero for all errors (#2599)

When building a customized Docker image containing pwndbg using ubuntu:20.04 as base, the build process does not fail even when setup.sh exits because Ubuntu 20.04 isn't supported anymore.

I think setup.sh should make the Docker image build process fail by emitting non-zero return values.
pull/2600/head
koalajoe23 1 year ago committed by GitHub
parent 53f77ad6a5
commit 028fc7b757
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -161,7 +161,7 @@ if linux; then
install_pacman install_pacman
else else
echo "\"$distro\" is not supported and your distro don't have a package manager that we support currently." echo "\"$distro\" is not supported and your distro don't have a package manager that we support currently."
exit exit 2
fi fi
;; ;;
esac esac
@ -169,7 +169,7 @@ fi
if ! hash gdb; then if ! hash gdb; then
echo "Could not find gdb in $PATH" echo "Could not find gdb in $PATH"
exit exit 3
fi fi
# Find the Python version used by GDB. # Find the Python version used by GDB.
@ -186,7 +186,7 @@ if [[ -z "$is_supported" ]]; then
echo "Your system has unsupported python version. Please use older pwndbg release:" echo "Your system has unsupported python version. Please use older pwndbg release:"
echo "'git checkout 2024.08.29' - python3.8, python3.9" echo "'git checkout 2024.08.29' - python3.8, python3.9"
echo "'git checkout 2023.07.17' - python3.6, python3.7" echo "'git checkout 2023.07.17' - python3.6, python3.7"
exit exit 4
fi fi
# Install Poetry # Install Poetry

Loading…
Cancel
Save