From 028fc7b757330bd4a1947762f4c4fb7a456d36a8 Mon Sep 17 00:00:00 2001 From: koalajoe23 Date: Wed, 4 Dec 2024 23:57:00 +0100 Subject: [PATCH] Make setup.sh return non-zero for all errors (#2599) When building a customized Docker image containing pwndbg using ubuntu:20.04 as base, the build process does not fail even when setup.sh exits because Ubuntu 20.04 isn't supported anymore. I think setup.sh should make the Docker image build process fail by emitting non-zero return values. --- setup.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/setup.sh b/setup.sh index 0ea47a4b2..54d9ceb12 100755 --- a/setup.sh +++ b/setup.sh @@ -161,7 +161,7 @@ if linux; then install_pacman else echo "\"$distro\" is not supported and your distro don't have a package manager that we support currently." - exit + exit 2 fi ;; esac @@ -169,7 +169,7 @@ fi if ! hash gdb; then echo "Could not find gdb in $PATH" - exit + exit 3 fi # Find the Python version used by GDB. @@ -186,7 +186,7 @@ if [[ -z "$is_supported" ]]; then echo "Your system has unsupported python version. Please use older pwndbg release:" echo "'git checkout 2024.08.29' - python3.8, python3.9" echo "'git checkout 2023.07.17' - python3.6, python3.7" - exit + exit 4 fi # Install Poetry